Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverting on dashboard results in internal server error for certain changes #44259

Open
maxzheng opened this issue Jun 14, 2024 · 0 comments
Open
Labels
.Backend Priority:P2 Average run of the mill bug Reporting/Dashboards .Team/DashViz Dashboard and Viz team Type:Bug Product defects

Comments

@maxzheng
Copy link
Contributor

maxzheng commented Jun 14, 2024

Describe the bug

When reverting change on dashboard, it is getting 500 internal server error. This seems to be the case for certain changes. If a change can't be reverted, it will result in the error. I would imagine all changes should be revertible? If there are irreversible changes, then a proper error should be shown to the user.

To Reproduce

  1. Go to any dashboard. Edit: Seems to happen to certain changes on dashboards that aren't revertible (maybe card modifications?). E.g. Stats Homepage or Piespace Revenue
  2. Open info sidebar and click on revert
  3. Nothing happens / check console log to see internal server error

Expected behavior

Revert to selected version no matter what

Logs

POST .../api/revision/revert 500 (Internal Server Error)

Information about your Metabase installation

master on Postgres

Severity

Can't revert automatically so gotta manually do it

Additional context

No response

@maxzheng maxzheng added Type:Bug Product defects Priority:P2 Average run of the mill bug labels Jun 14, 2024
@maxzheng maxzheng changed the title Reverting on dashboard results in internal server error Reverting on dashboard results in internal server error for certain changes Jun 14, 2024
@kamilmielnik kamilmielnik added .Backend .Team/DashViz Dashboard and Viz team and removed .Needs Triage labels Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.Backend Priority:P2 Average run of the mill bug Reporting/Dashboards .Team/DashViz Dashboard and Viz team Type:Bug Product defects
Projects
None yet
Development

No branches or pull requests

3 participants