fix(cache): Fix two bugs in Admin / Performance #44255
Merged
+160
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
rafpaf
changed the title
rafpaf
force-pushed
the
fix-adaptive-policy-bug
branch
from
b738277
to
2a6d189
Compare
rafpaf
added
the
backport
Graphite App
rafpaf
changed the title
rafpaf
commented
Jun 14, 2024
Graphite Automations"Warn authors when publishing large PRs" took an action on this PR • (06/14/24)1 teammate was notified to this PR based on Raphael Krut-Landau's automation. |
|
rafpaf
force-pushed
the
fix-adaptive-policy-bug
branch
from
2a6d189
to
f20ab3b
Compare
rafpaf
changed the title
rafpaf
force-pushed
the
fix-adaptive-policy-bug
branch
from
0055de3
to
880026f
Compare
sloansparger
previously requested changes
Jun 17, 2024
frontend/src/metabase/admin/performance/hooks/useSaveStrategy.tsx
Outdated
Show resolved
Hide resolved
- When adaptive policy is saved, it's not shown on the page - 12:00PM cannot be used as a time in the Schedule component - Clear cache when switching strategy to "Don't cache results"
…tion which also fixes the failing unit test
rafpaf
force-pushed
the
fix-adaptive-policy-bug
branch
from
40fdac1
to
35bed5c
Compare
rafpaf
changed the title
|
#44249 Still seems to be broken |
rafpaf
dismissed
sloansparger’s stale review
Nick has now approved this PR after Sloan's changes
rafpaf
added a commit
that referenced
this pull request
Jun 19, 2024
rafpaf
added a commit
that referenced
this pull request
Jun 20, 2024
* fix(cache): Fix two bugs in Admin / Performance (#44255) Ensures that minimum query durations are correctly displayed in the form post-save (#44249) and that all times can be used in the Schedule component (#44257) --------- Co-authored-by: Raphael Krut-Landau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #44249: When a new minimum query duration is added to an adaptive policy, it disappears from the form on save.
Closes #44257: Aberrant edge case: 12:00PM cannot be used as a time in the Schedule component.