Fix metabase lib returning the string "null" as the drill through value #44234
+29
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piranha
force-pushed
the
fix-string-null-quick-drill
branch
from
c3ce99f
to
92a4647
Compare
|
bshepherdson
requested changes
Jun 17, 2024
nemanjaglumac
force-pushed
the
fix-string-null-quick-drill
branch
from
b2c2a9d
to
ba6d5ba
Compare
bshepherdson
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44232
Description
This PR is reusing the technique that already existed, in which we'd check if the
:valueis a keyword:nulland returnnilinstead. That logic is now encapsulated in a newdrill-value->jsfunction.So after we fixed the
:null- > `"null", we're left with one more transformation.In Clojure,
nilissequable, so it was hitting this condition. So we ended up converting an empty list()into an empty array[]because of this line.Credits and kudos to @piranha for helping me debug this, and for fixing the latter issue.
How to verify
Follow the repro steps from the original issue and confirm that the value is now a proper JS
null.Checklist