Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing padding from cartesian chart item labels in embedding SDK #44226

Closed
Tracked by #42694
heypoom opened this issue Jun 14, 2024 · 1 comment
Closed
Tracked by #42694

Missing padding from cartesian chart item labels in embedding SDK #44226

heypoom opened this issue Jun 14, 2024 · 1 comment
Assignees
Labels
Embedding/SDK Embedding SDK for React .Team/Embedding

Comments

@heypoom
Copy link
Contributor

heypoom commented Jun 14, 2024

Chart padding was removed due to the isEmbeddingSdk check in getChartPadding, which makes it so that there is no padding between cartesian chart item labels and the dashboard card container.

const getChartPadding = ({
  isEmbeddingSdk,
  isQueryBuilder,
}: CartesianChartRootProps) => {
  if (isEmbeddingSdk) {
    return "0rem";
  }
  if (isQueryBuilder) {
    return "1rem 1rem 1rem 2rem";
  }

  return "0.5rem 1rem";
};
@heypoom heypoom changed the title Missing padding from cartesian chart item labels in embedding environments Missing padding from cartesian chart item labels in embedding SDK Jun 14, 2024
@heypoom heypoom added .Team/Embedding Embedding/SDK Embedding SDK for React labels Jun 14, 2024
@heypoom heypoom self-assigned this Jun 17, 2024
@heypoom heypoom closed this as completed Jun 20, 2024
@heypoom
Copy link
Contributor Author

heypoom commented Jun 20, 2024

Closed by #44283

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Embedding/SDK Embedding SDK for React .Team/Embedding
Projects
None yet
Development

No branches or pull requests

1 participant