Restoring a bookmarked entity (dashboard/question/metric) leads to application crash

[romeovs]

Describe the bug

Restoring a bookmarked metric results in an application crash (js).

Metric.A.Metabase.-.14.June.2024.mp4

To Reproduce

1. Navigate to a metric
2. Bookmark the metric
3. Move the metric to trash
4. Restore the metric

Expected behavior

No response

Logs

No response

Information about your Metabase installation

{
  "browser-info": {
    "language": "en-US",
    "platform": "MacIntel",
    "userAgent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:126.0) Gecko/20100101 Firefox/126.0",
    "vendor": ""
  },
  "system-info": {
    "file.encoding": "UTF-8",
    "java.runtime.name": "OpenJDK Runtime Environment",
    "java.runtime.version": "11.0.20.1+1",
    "java.vendor": "Eclipse Adoptium",
    "java.vendor.url": "https://adoptium.net/",
    "java.version": "11.0.20.1",
    "java.vm.name": "OpenJDK 64-Bit Server VM",
    "java.vm.version": "11.0.20.1+1",
    "os.name": "Mac OS X",
    "os.version": "14.2.1",
    "user.language": "en",
    "user.timezone": "Europe/Amsterdam"
  },
  "metabase-info": {
    "databases": [
      "h2"
    ],
    "hosting-env": "unknown",
    "application-database": "h2",
    "application-database-details": {
      "database": {
        "name": "H2",
        "version": "2.1.214 (2022-06-13)"
      },
      "jdbc-driver": {
        "name": "H2 JDBC Driver",
        "version": "2.1.214 (2022-06-13)"
      }
    },
    "run-mode": "dev",
    "version": {
      "date": "2024-06-12",
      "src_hash": "7a87e1a1173927a489fc70b6fc3e9bded123a326",
      "tag": "v1.2.0-SNAPSHOT",
      "hash": "3afe482"
    },
    "settings": {
      "report-timezone": null
    }
  }
}

Severity

P2

Additional context

No response

[NevRA]

@dpsutton is not related to the Metricsv2, so re-assigned AdminWebApp

[perivamsi]

Screen.Recording.2024-06-18.at.9.44.59.AM.mov

[ranquild]

@npfitz can we close this issue since your PR is merged?

[npfitz]

Yup. PR is merged in release branch. PR to master is up and pending.