Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix swiftlint in source code #250

Open
merlos opened this issue May 28, 2023 · 1 comment
Open

Fix swiftlint in source code #250

merlos opened this issue May 28, 2023 · 1 comment
Labels
code refactor
Milestone
1.10.0

Comments

@merlos
Copy link
Owner

merlos commented May 28, 2023

When swiflint is run it displays more than 260 issues

image

It should be reduced, ideally to 0.

Note: In the refactor, whenever there is a disable it should be documented why.
@merlos merlos added this to the 1.9.0 milestone May 28, 2023
@merlos merlos mentioned this issue Jun 1, 2023
Merged
@merlos merlos modified the milestones: 1.9.0, 1.10.0 Jun 2, 2023
@merlos
Copy link
Owner Author

merlos commented Jun 2, 2023

Many of the messages were fixed in #249.
There was a large majority of warnings due to the use of //this is my comment instead of // this is my comment (fixed adding a space after //).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code refactor
Projects
None yet
Milestone
1.10.0
Development

No branches or pull requests
1 participant
@merlos