Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: During transaction import, when user returns back to "mappings" step, all columns have reset in the forms #861

Open
1 of 2 tasks
zachgoll opened this issue Jun 11, 2024 · 0 comments
Open
1 of 2 tasks

Bug: During transaction import, when user returns back to "mappings" step, all columns have reset in the forms #861

zachgoll opened this issue Jun 11, 2024 · 0 comments
Labels
🐛 Bug Something isn't working

Comments

@zachgoll
Copy link
Collaborator

Where did this bug occur?

  • Local development
  • Self hosted app (i.e. Docker)

Describe the bug
A clear and concise description of what the bug is.

  • Column mappings reset when user returns to "configure" step
  • Additionally, for imports with large number of rows, the "Save" request for the column mappings is very slow

While this does not cause any immediate problems, it is an inconvenience to the user if they want to "re-map" their columns.

To Reproduce
Steps to reproduce the behavior:

  1. Go to transaction import
  2. Paste a CSV
  3. Map your columns
  4. Manually go back to the "Configure" step, and you should see that all the form fields have reset to the same column

Expected behavior
A clear and concise description of what you expected to happen.

The "configure" step should retain the same mappings the user set originally.

Screenshots / Recordings
If applicable, add screenshots or short video recordings to help show the bug in more detail.

CleanShot.2024-06-11.at.10.08.21.mp4

Additional context
Add any other context about the problem here.
@zachgoll zachgoll added the 🐛 Bug Something isn't working label Jun 11, 2024
igorcarvalhh added a commit to igorcarvalhh/maybe that referenced this issue Jun 24, 2024
@igorcarvalhh
Fix issue maybe-finance#861: Correct header selection logic in get_se…
017c1e4 
…lected_header_for_field method

The get_selected_header_for_field method was incorrectly using the entire field object instead of the field key to dig into the column_mappings hash. This caused an error when trying to retrieve the selected header for a field.
@igorcarvalhh igorcarvalhh mentioned this issue Jun 24, 2024
Merged
zachgoll pushed a commit that referenced this issue Jun 24, 2024
@igorcarvalhh
Fix issue #861: Correct header selection logic in get_selected_header…
094128f 
…_for_field method (#918)

The get_selected_header_for_field method was incorrectly using the entire field object instead of the field key to dig into the column_mappings hash. This caused an error when trying to retrieve the selected header for a field.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zachgoll