Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make account "History" and "Transactions" sections more clear #838

Open
zachgoll opened this issue Jun 5, 2024 · 2 comments
Open

Make account "History" and "Transactions" sections more clear #838

zachgoll opened this issue Jun 5, 2024 · 2 comments
Assignees
Labels
💡 Improvement Improvements to an existing feature or flow

Comments

@zachgoll
Copy link
Collaborator

zachgoll commented Jun 5, 2024

Overview

It is currently a bit confusing looking at an account's "history" and "transactions":

CleanShot 2024-06-05 at 16 36 23

CleanShot 2024-06-05 at 16 36 54

It is not clear to the user how they should be modifying the value of an account and how the changes they make affect the account's value.

Proposed solution

  • Change "History" -> "Value" to clarify that this list is a history of account values over time
  • Add daily balances to the "Value" tab (should match the line chart above)
    • We could remove duplicate balances if that's more clear? (i.e. when the account balance doesn't change day over day)
    • This will require a slight rework since currently, we're only displaying a list of Valuation records. To maintain the editing UX, we'll have to change from displaying Valuation records to displaying Account::Balance records. Since Account::Balance records should not be editable directly, this UX will act as a proxy for editing Valuation records (i.e. if there is a Valuation on the date, modify it, otherwise, create it)
@zachgoll zachgoll added the 💡 Improvement Improvements to an existing feature or flow label Jun 5, 2024
@flacnut
Copy link

flacnut commented Jun 7, 2024

My initial instinct is that having a daily valuation history table at an account level is not very helpful.

I recently ran into an issue, creating a real estate asset and then setting a valuation today, and a valuation 10 years ago. Selecting to view "all" history in the chart crashed the app.

The usefulness is also dependent on the account type:

History tab won't be useful for things like real estate, where the values change very rarely.

For transactional accounts like credit cards or bank accounts, the history and the transaction pages make more sense to be merged.

For securities or crypto which do have daily valuation changes independent of buy/sell behavior (transactions), I can see value in a history tab. But is daily the right granularity here? Especially at > 1 year of history getting viewed. Is this history information helpful since we have the chart? What would be more useful I think is a stacked area chart option showing the contribution of each security to the overall up/down trend.

@zachgoll
Copy link
Collaborator Author

@flacnut I agree that we should consider deleting it altogether. We can always add it back and early on it's probably best to error on the "minimalist" side until we're 100% clear what users find valuable.

To address a few specific points:

I recently ran into an issue, creating a real estate asset and then setting a valuation today, and a valuation 10 years ago. Selecting to view "all" history in the chart crashed the app.

As this is more performance related, I wouldn't necessarily group this as something holding us back from showing a history. But this is definitely worth a fix through either setting time series intervals or limiting the history we show.

History tab won't be useful for things like real estate, where the values change very rarely.

In the future, I'm imagining that we'll allow users to connect a Zillow (or other 3rd party) valuation service and fetch an updated valuation every X weeks/months, which could be useful to see over time.

For transactional accounts like credit cards or bank accounts, the history and the transaction pages make more sense to be merged.

Agreed.

For securities or crypto which do have daily valuation changes independent of buy/sell behavior (transactions), I can see value in a history tab. But is daily the right granularity here? Especially at > 1 year of history getting viewed. Is this history information helpful since we have the chart?

All historical info is calculated and synced on a daily basis, so in theory, all the expensive work done here will happen in the background. That said, I do agree that it adds some redundancy to the graph and may not be needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡 Improvement Improvements to an existing feature or flow
Projects
None yet
Development

No branches or pull requests

2 participants