Add avatar icon as login property w/ default. #9917
+11
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slax57
reviewed
Jun 12, 2024
There was a problem hiding this comment.
Thanks for the PR, which I approve.
However, since this is a new feature, it needs to target the next branch. Can you rebase?
As a reminder, React Admin v4 is now feature-freeze, which means this new feature will have to be released with React Admin v5.
Thanks again for your contribution!
mjarosch
force-pushed
the
feature/login-avatar-icon
branch
from
eaa60f5
to
1cf7f23
Compare
mjarosch
force-pushed
the
feature/login-avatar-icon
branch
3 times, most recently
from
a91a5be
to
7755320
Compare
|
@slax57 Branch has been rebased. |
|
Would you mind adding a story for it? We don't have any for this component so take inspiration from the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request for issue #9916. It adds an avatarIcon property to the Login component w/ a default of the Lock icon. This allows for overriding the icon without having to copy the complete component.
Ideally, this would be included as part of a v4 point release. This is my first pull request, so please let me know if there is anything else needed.
--
Fix #9916