-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom DKIM selector #2348
Comments
I had a quick look over the source code, seems easy. However, some questions as I'm not familiar with python
|
I have some commits here main...bilogic:mailinabox:custom-dkim-selector, apologies that it is mixed in with a configurable TTL feature. The main change is on line 792 of My problem is, why does the |
#2220 replaces OpenDKIM with dkimpy. My recommendation would be to work with @kiekerjan as your changes seem reasonable to me as I have issues with using Then, ideally, this stimulates getting the PR merged. |
Look at the dkim.sh script in the setup directory. There the default dns entry is generated. Also, in start.sh you might want to use something like DKIM_SELECTOR=${DEFAULT_DKIM_SELECTOR:-mail} Your current code will always use mail as selector (and overwrite anything else) |
Just finished a hardware migration. Thank you for the info, let me find some time to review them. But 1 quick qn first, is the maintainer open to accepting dkimpy first? |
python and bash are like my 5th language 🤣 Definitely configurable (and not just something different). Since we are going to change it, let's provide an end-all solution. From the looks of it, this is not a very big change here, so if and when we switch to dkimpy, I would be happy to help.
Thanks! |
My new branch with the key bits here b51550d Please help me to review. Thank you. |
Hi!
Is it possible to specify another DKIM selector other than
mail
?The text was updated successfully, but these errors were encountered: