Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FQIN in Dockerfile #9841

Open
achrinza opened this issue Aug 13, 2023 · 0 comments · Fixed by #9842
Open

Use FQIN in Dockerfile #9841

achrinza opened this issue Aug 13, 2023 · 0 comments · Fixed by #9842

Comments

@achrinza
Copy link
Member

achrinza commented Aug 13, 2023

Historically, we have used Unqualified Image Names. However, this is insecure as it is ambiguous on registry to use. Fully Qualified Image Names (FQIN) make explicit the domain name of the registry to pull from.

Change details

For Dockerfiles, the general update will be:

+ FROM docker.io/library/node:18-slim
- FROM node:18-slim

Although there is special-handling for the docker.io registry that allows omission of /library namespace path prefix for "no-namespace" images, we should use the full FQIN so as to be consistent with the output of other utilities such as podman image ls.

Impact

Other than updated Dockerfiles, there should be no other noticeable impact.

Files to update

References

Similar changes in other projects

achrinza added a commit that referenced this issue Aug 13, 2023
see: #9841
Signed-off-by: Rifa Achrinza <[email protected]>
achrinza added a commit that referenced this issue Aug 18, 2023
see: #9841
Signed-off-by: Rifa Achrinza <[email protected]>
@achrinza achrinza linked a pull request Aug 18, 2023 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant