Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version string of the Logseq static build not easily identifyable in SPA build #20

Open
acsr opened this issue Dec 11, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@acsr
Copy link

acsr commented Dec 11, 2023

It is not easy to identify the version of the used Logseq static build and the publish-spa version that was used during publication.

It would help a lot if (at least as a debug option) the version tag of publish-spa and the logseq static build is included either in the html source as metadata or in the SPA UI reachable over an about link in the help section.

Why is adding your own page not sufficient?
The purpose is to have a proof of the actual used version instead of the intended versions, to spot misconfiguration or failed attempts to update the code.

challenges

  • The commandline command logseq-publish-spa has no --version output option or drops it during execution
  • The command logseq-publish-spa has no verbose option to dump the version of the static logseq build, you just rely on the given path.

If not available like suggested:

  • how can the version be retrieved manually from the final SPA build or from the installed code?
  • the actual state of the checkout (git status) is not enough, since the yarn install does not offer useful output in his warnings.
  • the full (re-)install command I used was:
    logseq % yarn install --frozen-lockfile && yarn gulp:build && clojure -M:cljs release publishing
    
    • Maybe there is a different syntax necessary to update properly
@logseq-cldwalker
Copy link
Contributor

logseq-cldwalker commented Jan 9, 2024

Hi. I've wanted published graphs to have the frontend (static) version they're built with available. I'll see if we can I do this in the next week or two. I'm less interested in the CLI printing the static version as that is easy to get with cd ../logseq && git rev-parse HEAD

@logseq-cldwalker logseq-cldwalker added the enhancement New feature or request label Jan 9, 2024
@acsr
Copy link
Author

acsr commented Jan 15, 2024

Thanks for the hint with git rev-parse HEAD.
but to get a lazy human readable version string, I need to invest more braingrease ;-), drill down to the file containing the versions string and grep for it. This is for another day. Step by step into the future… Using my timemachine to fast forward to your solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants