Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exclude option to internal-services in Spring integration #5753

Open
ikhoon opened this issue Jun 12, 2024 · 0 comments
Open

Add exclude option to internal-services in Spring integration #5753

ikhoon opened this issue Jun 12, 2024 · 0 comments
Milestone

Comments

@ikhoon
Copy link
Contributor

ikhoon commented Jun 12, 2024

internal-service provides include options to opt in services to serve only in the non-service port. But exclude isn't supported to opt out of include. exclude option will be useful for less sensitive internal services. For example, in the case of the health check service, there will be a need to provide both the service port and the internal port because sensible information is not exposed by HealthCheckService if updating the status isn't supported in the API.

armeria:
  ports:
    - port: 8080
      protocol: HTTP
  health-check-path: /...
  internal-services:
    exclude: HEALTH
    port: 9090

In addition to exclude, multiple internal service configurations would be helpful to respond to complex situations.

armeria:
  ports:
    - port: 8080
      protocol: HTTP
  internal-services:
    - include: DOCS
      port: 9090
    - include: HEALTH
      port: 9091
    ...
@ikhoon ikhoon added this to the 1.30.0 milestone Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant