Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Crashes with 0.80 #105

Open
AJolly opened this issue May 19, 2024 · 8 comments
Open

馃悰 Crashes with 0.80 #105

AJolly opened this issue May 19, 2024 · 8 comments
Labels
bug Something isn't working help wanted Should implement/fix, but unable due to complexity or time constraints. Welcoming community input. unknown Further testing is needed

Comments

@AJolly
Copy link

AJolly commented May 19, 2024

I get frequent crashes with 0.8 that I do not with 0.78

Logs (please upload or provide link to you log):

2024-05-18.txt

Version:

  • PowerToy: v.0.80.1
  • Everything: 1.5.0.1373a
  • EverythingPT:
  • Windows: 22635.3575
@AJolly AJolly added the bug Something isn't working label May 19, 2024
@AJolly
Copy link
Author

AJolly commented May 19, 2024

I take that back, I do get them with 0.80 as well.

@lin-ycv
Copy link
Owner

lin-ycv commented May 20, 2024

does this happen with specific files/directory? have you notice if a certain search query causes the issue? Does it crash when searching with Everything instead of this plugin?

My best guess would be is whatever you're searching for is deeply nested, and the path is over 260 characters.

Error from log

[2024-05-18 14:15:06.0089] [ERROR] [C:\Users\Lin\Documents\repos\PowerToys\src\modules\launcher\Plugins\EverythingPowerToys\Main.cs::163]
-------------------------- Begin exception --------------------------
Message: Everything Exception

Exception full name : System.ArgumentException
Exception message : title cannot be null or empty (Parameter 'title')
Exception stack trace:
at Community.PowerToys.Run.Plugin.Everything.Everything.Query(String query, Settings setting)+MoveNext()
at System.Collections.Generic.List1.AddRange(IEnumerable1 collection)
at Community.PowerToys.Run.Plugin.Everything.Main.Query(Query query, Boolean delayedExecution)
Exception source : Community.PowerToys.Run.Plugin.Everything
Exception target site: Boolean MoveNext()
Exception HResult : -2147024809
-------------------------- End exception --------------------------

The error points to this

results.AddRange(_everything.Query(searchQuery, _setting));

Which is most likely caused by something here
char[] buffer = new char[260];
uint length = Everything_GetResultFullPathName(i, buffer, (uint)buffer.Length);
string fullPath = new(buffer, 0, (int)length);
string name = Path.GetFileName(fullPath);
bool isFolder = Everything_IsFolderResult(i);
string path = isFolder ? fullPath : Path.GetDirectoryName(fullPath);
string ext = Path.GetExtension(fullPath.Replace(".lnk", string.Empty));
var r = new Result()
{
Title = name,

@lin-ycv lin-ycv changed the title Crashes with 0.80馃悰 xx 馃悰 Crashes with 0.80 May 20, 2024
@AJolly
Copy link
Author

AJolly commented May 21, 2024

Given how frequently i see that error, im not sure im searching for anything long. Is there a debug mode I can run it in to log?

@lin-ycv
Copy link
Owner

lin-ycv commented May 22, 2024

Is there a debug mode I can run it in to log?

Try the new version, if it still crashes, use the debug dll and upload the log that's saved on the desktop

@qianzyGit
Copy link

qianzyGit commented May 26, 2024

It seems like I have the same issue too. Even after updating to version 81, it still causes the powertoy

@lin-ycv
Copy link
Owner

lin-ycv commented May 26, 2024

Please turn on debug option in 81 and provide the desktop logs.

@lin-ycv
Copy link
Owner

lin-ycv commented May 29, 2024

@AJolly @qianzyGit can you provide desktop logs after setting the debug option in settings to verbose?

@qianzyGit
Copy link

EverythingPT.log

@lin-ycv lin-ycv added help wanted Should implement/fix, but unable due to complexity or time constraints. Welcoming community input. unknown Further testing is needed labels Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Should implement/fix, but unable due to complexity or time constraints. Welcoming community input. unknown Further testing is needed
Projects
None yet
Development

No branches or pull requests

3 participants