zlib-devel dependency missing in the install guide

[dylanbob]

Hi
I've tried compiling magma from a fresh (and updated) CentOS 7

Following the guide, eventually compiling : make all
Got an error output telling me openssl-build failed. Then I manually executed the lib building script, and read the error in the script : #include <zlib.h> the file couldn't be found.

Fixed this by installing zlib-devel : yum install -y zlib-devel
Shouldn't you add it to the install guide ?

[ladar]

Technically zlib is bundled, and gets compiled before OpenSSL. So the real bug is that the build.lib.sh script isn't passing the right options to configure so that OpenSSL looks internally for zlib.h. There may be other subtle reference issues like that in the install script that have been overlooked because we typically compile it using dev environments that already have the necessary packages installed. Checkout the dev/scripts/builders/build.lib.sh file, and look for the openssl() function. It should be a simple fix.

…

On 07/06/2017 05:18 PM, Dylan wrote: Hi I've tried compiling magma from a fresh (and updated) CentOS 7 Following the guide, eventually compiling : |make all| Got an error output telling me *openssl-build failed*. Then I manually executed the lib building script, and read the error in the script : |#include <zlib.h>| the file couldn't be found. Fixed this by installing zlib-devel : |yum install -y zlib-devel| Shouldn't you add it to the install guide ? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#100>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABXhmHCDdZWGVu_K1lmKrOKbUIsL2V89ks5sLV0ygaJpZM4OQQb0>.

[necrose99]

https://asciinema.org/a/YeqTp3svZIH1DZ58K0zA7zbpY