This is very hard to think about what's happening.

Why can't we just do the following:

• change withLogging to do more-or-less exactly what's ListResource is doing [check if TaskFrom is non-nil and if so append to it]
• not change anything else...

change withLogging to do more-or-less exactly what's ListResource is doing [check if TaskFrom is non-nil and if so append to it]

Actually my first attempt was like that. But it caused cycle import if we call TaskFrom in httplog. Let me try if I can work this around.

Not sure if it's an overkill to move routine filter in a separate directory to tackle the cycle import issue. But it should be what you suggested.

can you explain a bit what would happen when logInRoutine = true?

We added a feature to run the watch serving in a separate goroutine to free stack memory allocated by Golang runtime (#120902). This code determines if it is the case and run the rl.log() at the end of the aforementioned goroutine.

I also added comment to explain that a bit. Thanks!

nit: I would switch to sth like;

var logFunc func()
logFunc = rl.Log
defer func() {
  if logFunc != nil {
    logFunc()
  }
}()

Let's put more context into this comment - I don't think it clarifies enough for people not familiar with it.

// We need to ensure that the request is logged after it is processed.
// In case the request is executed in a separate goroutine (created via
// WithRoutine handler in the handler chain), we want the logging to
// happen in that goroutine too, so we append it to the task.

Hmm - when calling AppendTask, the main function is not yet set, right?
So won't it be overwritten later anyway?

I would like to see test output to see we actually fixed the problem.

This deserves some unit test.