Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import GCE resources #164

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Import GCE resources #164

wants to merge 4 commits into from

Conversation

sawsa307
Copy link
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:
Import resources needed by GCE provider.

Which issue(s) this PR fixes:
Fixes #87

Does this PR introduce a user-facing change?:

None

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 22, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sawsa307
Once this PR has been reviewed and has the lgtm label, please assign liorlieberman for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 22, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 22, 2024
@sawsa307 sawsa307 marked this pull request as draft June 22, 2024 02:20
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 22, 2024
@k8s-ci-robot
Copy link
Contributor

@sawsa307: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-ingress2gateway-verify 8c08a09 link true /test pull-ingress2gateway-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sawsa307 sawsa307 changed the title Update reader Update GCE resource reader Jun 22, 2024
@sawsa307
Copy link
Contributor Author

Wait until we finalized on how we should introduce gateway and ingress extension. See #148 (comment)

@sawsa307 sawsa307 changed the title Update GCE resource reader Import GCE resources Jun 22, 2024
@sawsa307
Bump golangci-lint version.
9049eae 
* go.mod requires go 1.22.4, while golangci-lint 1.55.2 is built on go
  1.21. This would cause an issue to load go package.
  "go.mod requires go >= 1.22.1 (running go 1.22.0; GOTOOLCHAIN=local)"
* Thus, we need to update to the latest goclint-ci version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levikobi levikobi Awaiting requested review from levikobi

@Xunzhuo Xunzhuo Awaiting requested review from Xunzhuo

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for GCE ingress class/provider
2 participants
@sawsa307 @k8s-ci-robot