Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure generated Gateway-API object fields obey kubebuilder max item validation #124

Open
levikobi opened this issue Jan 16, 2024 · 3 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@levikobi
Copy link
Member

What would you like to be added:
Add a mechanism that considers the kube-builder max item validation on Gateway-API list fields. See this for example.

One option is to validate the constraint, and if it is exceeded - throw an appropriate message.
Another option is to add conversion logic that splits objects by these constraints, which will be more challenging.

Why this is needed:
To help migrating users who violate those constraints. See kubernetes-sigs/gateway-api#2501 as an example.

@levikobi levikobi added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 16, 2024
@levikobi
Copy link
Member Author

/help

@k8s-ci-robot
Copy link
Contributor

@levikobi:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jan 16, 2024
@swastik959
Copy link

hi , I am interested in this issue
/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants