You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What would you like to be added:
This issue is for tracking the changes discussed in #3130 (comment)... tl;dr being that MakeRequestAndExpectEventuallyConsistentResponse() should not close an externally passed gRPC client.
Why this is needed:
The same client could be getting used across multiple tests in parallel. Closing the client should be the responsibility of the place where it was created (and not necessarily within the place where the client gets used)
Makes sense to me - would this change just be moving the defer c.Close() one line up to within the if c == nil conditional and adding a test to confirm it doesn't get closed when a non-nil connection is passed in?
Is there a parallel concern for the HTTP helper too? I'd expect these should have consistent behavior.
What would you like to be added:
This issue is for tracking the changes discussed in #3130 (comment)... tl;dr being that
MakeRequestAndExpectEventuallyConsistentResponse()
should not close an externally passed gRPC client.Why this is needed:
The same client could be getting used across multiple tests in parallel. Closing the client should be the responsibility of the place where it was created (and not necessarily within the place where the client gets used)
/cc @snehachhabria
The text was updated successfully, but these errors were encountered: