Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Request Timeouts for GRPCRoute #3139

Open
arkodg opened this issue Jun 7, 2024 · 3 comments
Open

Support Request Timeouts for GRPCRoute #3139

arkodg opened this issue Jun 7, 2024 · 3 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@arkodg
Copy link
Contributor

arkodg commented Jun 7, 2024

What would you like to be added:

A request.Timeout field within GRPCRoute similar to the one added in HTTPRoute as part of https://gateway-api.sigs.k8s.io/geps/gep-1742/

Why this is needed:

  1. Set a request timeout for unary rpc, that may vary from the default timeout of the implementation
  2. Disable timeouts (set to 0s) for streaming rpc
@arkodg arkodg added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 7, 2024
@arkodg
Copy link
Contributor Author

arkodg commented Jun 7, 2024

cc @robscott @frankbu @gnossen

@robscott
Copy link
Member

robscott commented Jun 8, 2024

Good call @arkodg! I think this one should be relatively straightforward, but because it's a new API field in a GA resource, we'll likely need to track it with a separate GEP. Do you mind adding this to #3103 if you think you'd have time to lead this in v1.2?

@arkodg
Copy link
Contributor Author

arkodg commented Jun 8, 2024

sure @robscott done

@robscott robscott added this to the v1.2.0 milestone Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants