Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hook points support in conformance test suite #3131

Open
shawnh2 opened this issue Jun 4, 2024 · 7 comments
Open

Add hook points support in conformance test suite #3131

shawnh2 opened this issue Jun 4, 2024 · 7 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@shawnh2
Copy link
Contributor

shawnh2 commented Jun 4, 2024

What would you like to be added:

Add the hook point support for current conformance test suite.

For example, like AfterTestFail hook point, developers can attach various commands to this hook point, and programs that attach to this hook point wil only be executed if one conformance test is failed.

Why this is needed:

This will be super helpful for developers to debug the failed conformance test.

Sometimes the error trace reported by conformance test is not very useful. For example, we'd like to see the status/logs of specific resources (by attaching kubectl cmd to the hook which I described above could ease the pain), even some other configs that can be retrieved by other commands.

@shawnh2 shawnh2 added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 4, 2024
@k8s-ci-robot
Copy link
Contributor

@mlavacca: The label(s) /label needs-triage cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label needs-triage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

@mlavacca: The label(s) triage/needs cannot be applied, because the repository doesn't have them.

In response to this:

/triage needs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mlavacca
Copy link
Member

mlavacca commented Jun 4, 2024

/triage needs-triage

@k8s-ci-robot
Copy link
Contributor

@mlavacca: The label(s) triage/needs-triage cannot be applied, because the repository doesn't have them.

In response to this:

/triage needs-triage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@shaneutt shaneutt added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jun 4, 2024
@kflynn
Copy link
Contributor

kflynn commented Jun 4, 2024

This sounds like a good idea, yeah. Making it easier for developers to get value from the conformance tests, whether or not they're "part of the Gateway API", sounds like a Good Thing™. 🙂

@robscott
Copy link
Member

robscott commented Jun 4, 2024

Discussed in today's community meeting, this sounds like a great idea, thanks @shawnh2!

/triage accepted

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Jun 4, 2024
@shawnh2
Copy link
Contributor Author

shawnh2 commented Jun 6, 2024

Assign myself, since I've been working on something that is quite similar to this issue as well. I will post the initial design of this here once it's done.

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

6 participants