Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mount ConfigMap into container instead of fetching it from Apiserver #16

Open
MrHohn opened this issue Dec 17, 2016 · 22 comments
Open

Mount ConfigMap into container instead of fetching it from Apiserver #16

MrHohn opened this issue Dec 17, 2016 · 22 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Milestone

Comments

@MrHohn
Copy link
Member

MrHohn commented Dec 17, 2016

Kubernetes already provides ConfigMap mounting feature --- the mounted ConfigMap gets dynamically reloaded on disk on changes. It seems not wise to re-implement a mechanism provided by the cluster.

Beside, with current implementation the autoscaler has to be granted ConfigMap read access rights to the cluster. It also seems unfit because only one specific ConfigMap is needed for providing scaling parameters.

However, one problem with the ConfigMap mounting solution is that the container will not be started running if the ConfigMap is no exist(mount error), which means we need an initial process to create it ahead. This is not desired either, because we want to handle the entire lifecycle of ConfigMap by autoscaler itself.

Good news is folks already start working on the optional ConfigMap feature(kubernetes/community#175), which is also needed by kube-dns. We should consider re-write the ConfigMap polling logic here after this feature is implemented.

@bowei
Copy link
Contributor

bowei commented Jun 2, 2017

Optional config maps have landed.

@MrHohn MrHohn added this to the k8s v1.8 milestone Jun 2, 2017
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed enhancement labels Aug 22, 2018
@amrmahdi
Copy link

Are you still planning on changing the implementation? Do you have timelines?

@MrHohn
Copy link
Member Author

MrHohn commented Oct 30, 2018

@amrmahdi I might not have bandwidth to do this shortly, but would love to review and merge if someone else can pick this up :)

@MrHohn
Copy link
Member Author

MrHohn commented Oct 30, 2018

kube-dns has implemented similar functionality: https://github.com/kubernetes/dns/blob/master/pkg/dns/config/sync.go

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 26, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 26, 2019
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dudicoco
Copy link

/reopen

@k8s-ci-robot
Copy link
Contributor

@dudicoco: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dudicoco
Copy link

Are there any plans on implementing this issue? It would be best practice to create the configmap beforehand.

@afirth
Copy link

afirth commented May 11, 2021

@k8s-ci-robot
Copy link
Contributor

@afirth: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to this:

Still reffed downstream
https://github.com/kubernetes/kubernetes/blob/master/cluster/addons/dns-horizontal-autoscaler/dns-horizontal-autoscaler.yaml#L40

Worth fixing?
/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MrHohn
Copy link
Member Author

MrHohn commented May 11, 2021

Definitely worth fixing. If anyone can help send a PR that would speed things up quite a lot :)
/reopen

@k8s-ci-robot
Copy link
Contributor

@MrHohn: Reopened this issue.

In response to this:

Definitely worth fixing. If anyone can help send a PR that would speed things up quite a lot :)
/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this May 11, 2021
@MrHohn MrHohn added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label May 11, 2021
@MrHohn
Copy link
Member Author

MrHohn commented May 11, 2021

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label May 11, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 9, 2021
@afirth
Copy link

afirth commented Aug 16, 2021

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 16, 2021
@bowei
Copy link
Contributor

bowei commented Aug 16, 2021

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Aug 16, 2021
@ipochi
Copy link

ipochi commented Dec 26, 2022

I'd be willing to help and take the issue to completion, if this is still required ?

@MrHohn
Copy link
Member Author

MrHohn commented Dec 27, 2022

@ipochi Thanks for chiming in, yes this is still something we desired.

@ipochi
Copy link

ipochi commented Jan 3, 2023

I'd like some help , background context in order to accomplish the task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

9 participants