Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource tags cannot be modified after creation when aws-load-balancer-type is set to "nlb" #3750

Open
vjanelle opened this issue Jun 17, 2024 · 2 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@vjanelle
Copy link

Is your feature request related to a problem?
When attempting to update resource tags on existing load balancers, we are unable to mutate the values.

Debugging this with AWS, we determined that if the service.beta.kubernetes.io/aws-load-balancer-type value isn't set to external or nlb-ip, the load balancer controller will ignore the request. The in-tree service controller I think would modify the values, but it is passing all responsibility over to the aws-load-balancer-controller.

Describe the solution you'd like
When modifying resource tags with the aws-load-balancer-type set to nlb, the resource tags are updated, without having to recreate the nlbs.

Describe alternatives you've considered
We've considered modifying the aws-load-balancer-type to 'nlb-ip', but the documentation says this would lead to a resource leak.

@ChuksGrinage
Copy link
Contributor

Thank you for bringing this to our attention. We are currently attempting to reproduce this issue on our end. /kind/feature

@shraddhabang shraddhabang added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 19, 2024
@vjanelle
Copy link
Author

Thanks - a key thing is that the additional tags annotation has to be mutated after being set the first time. It'll work once, basically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants