Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The actual default RestartPolicy of PyTorch is inconsistent with its description in the CRD #2127

Open
Eslody opened this issue May 27, 2024 · 0 comments
Open

The actual default RestartPolicy of PyTorch is inconsistent with its description in the CRD #2127

Eslody opened this issue May 27, 2024 · 0 comments

Comments

@Eslody
Copy link

Eslody commented May 27, 2024

In manifests/base/crds/kubeflow.org_pytorchjobs.yaml, it is mentioned that:

description: Restart policy for all replicas within the job. One of Always, OnFailure, Never and ExitCode. Default to Never.

However, in the code of pkg/apis/kubeflow.org/v1/pytorch_types.go, the DefaultRestartPolicy is defined as OnFailure.

PyTorchJobDefaultRestartPolicy is default RestartPolicy for PyTorchReplicaSpec. PyTorchJobDefaultRestartPolicy = RestartPolicyOnFailure

This has caused some confusion. It is recommended that the true default value of RestartPolicy be clarified.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Eslody