SC2164

[zefir-git]

For bugs

• Rule Id (if any, e.g. SC1000): SC2164
• My shellcheck version (shellcheck --version or "online"): online
• The rule's wiki page does not already cover this (e.g. https://shellcheck.net/wiki/SC2086)
• I tried on https://www.shellcheck.net/ and verified that this is still a problem on the latest commit

Here's a snippet or screenshot that shows the problem:

#!/bin/zsh
function foo() {
    cd generated_files
    return $?
}

Here's what shellcheck currently says:

SC2164: suggested cd generated_files || exit

Here's what I wanted or expected to see:

No suggestion. The function returns on the next line anyways.

[brother]

The warning is correct. Ignore it with a directive if you don't like it.

[zefir-git]

If cd fails, it will return on the next line anyways.

this doesn't make sense:

cd generated_files || return $?
return $?

Isn't this like?

int result = cd("generated_files");
if (result == 1) return result;
return result;

|| return when the next line already is return seems redundant to me.