proposal: Reliability of kmesh restart #417
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wuchangye <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
hzxuzhonghu
reviewed
Jun 6, 2024
|
|
||
| In normal and abnormal restart scenarios, the data plane governance function is not affected, including: | ||
|
|
||
| 1. After the pod is restarted, it is automatically restored to the status before the restart. |
There was a problem hiding this comment.
Suggested change
| 1. After the pod is restarted, it is automatically restored to the status before the restart. | |
| 1. After kmesh daemon is restarted, it is automatically restored to the status before. |
hzxuzhonghu
reviewed
Jun 6, 2024
| In normal and abnormal restart scenarios, the data plane governance function is not affected, including: | ||
|
|
||
| 1. After the pod is restarted, it is automatically restored to the status before the restart. | ||
| 2. During the Kmesh restart, newly established links have the governance capability. |
There was a problem hiding this comment.
Suggested change
| 2. During the Kmesh restart, newly established links have the governance capability. | |
| 2. During the Kmesh restart, newly established connections should be governed by Kmesh. |
|
|
||
| 1. After the pod is restarted, it is automatically restored to the status before the restart. | ||
| 2. During the Kmesh restart, newly established links have the governance capability. | ||
| 3. After the Kmesh is restarted, the newly created link has the governance capability. |
| 2. During the Kmesh restart, newly established links have the governance capability. | ||
| 3. After the Kmesh is restarted, the newly created link has the governance capability. | ||
| 4. The governance capability of old links is not affected by restart. | ||
| 5. When Kmesh is deleted, resources can be completely cleared to avoid residual resources. |
There was a problem hiding this comment.
Suggested change
| 5. When Kmesh is deleted, resources can be completely cleared to avoid residual resources. | |
| 5. After Kmesh is uninstalled, resources should be completely cleared to avoid leaking resources. |
| 2. After the Kmesh is restarted, the configuration restoration module is added to restore the governance information of the pods managed by the Kmesh on the node. | ||
| 3. In the scenario where the Kmesh is deleted, the bpf prog and bpf map resources must be cleared in a timely manner to ensure that no resource leakage occurs. | ||
|
|
||
| When the Kmesh is started, the bpf prog and bpf map may already exist on the node. In this case, compatibility processing is required. |
There was a problem hiding this comment.
can you elaborate on compatibility processing
|
|
||
| | Scenario | workload model | Kmesh management | Kmesh byPass | Auth | waypoint Interconnection | | ||
| | ------------ | -------------- | ---------------- | ------------ | ---- | ------------------------------------------------------------ | | ||
| | Existed link | Y | Y | Y | Y | P(If the connection is complete but the send request has not been sent) | |
| - eBPF management | ||
|
|
||
| - To keep the governance capability during the Kmesh restart, you need to place the bpf prog and bpf map pin to the /sys/fs/bpf directory on the node. | ||
| - During the startup of the Kmesh, the BPF PROG is replaced and the BPF MAP is inherited. |
There was a problem hiding this comment.
BPF PROG is replaced
How will this influence the governing prog
| - Configure recovery | ||
|
|
||
| - Workload resources | ||
| - During the startup of the Kmesh, the local bpf map data is restored to the user-mode cache before the Kmesh subscribes to workload model data from the Istiod. |
There was a problem hiding this comment.
Based on offline discussion, how can user space cache be restored correctly is still not clear
| - During the startup of the Kmesh, the local bpf map data is restored to the user-mode cache before the Kmesh subscribes to workload model data from the Istiod. | ||
| - Incremental subscription to Istiod based on workload resources in the local cache; | ||
| - Kmesh management/byPass | ||
| - Move the management logic from kmesh-plg to kmesh-daemon. |
| - Authentication | ||
| - Restore the user-mode authentication cache information based on the authentication rule delivered by the Istiod. | ||
| - Waypoint interconnection | ||
| - Restore the user-mode authentication cache information based on the authentication rule delivered by the Istiod. The procedure is the same as that for restoring workload resources. |
|
|
||
| - Postponed clearance | ||
|
|
||
| When the Kmesh exits, start a delay clearing task on the node. If the Kmesh restarts abnormally, delete the scheduled task after the restart. |
There was a problem hiding this comment.
ALternatively we can detect whether there is a new kmesh daemon pod in the same node. And only clear the resources if no such pod exists
|
|
||
| #### Status Quo and Strategy Analysis | ||
|
|
||
| The following uses the workload mode as an example to describe the operations on each BPF map during Kmesh governance: |
There was a problem hiding this comment.
Is it a bpf map or a BPF map. In this article it needs to be standardised
|
|
||
| - The bpf prog and map need to be maintained during restart. | ||
|
|
||
| - After the Kmesh is restarted: |
There was a problem hiding this comment.
Suggested change
| - After the Kmesh is restarted: | |
| - After Kmesh restart: |
| - The bpf prog and map need to be maintained during restart. | ||
| - After the Kmesh is started, the data in the map needs to be restored and the data needs to be synchronized with the control plane. | ||
|
|
||
| Note: Currently, Kmesh supports only link-level authentication. |
There was a problem hiding this comment.
Suggested change
| Note: Currently, Kmesh supports only link-level authentication. | |
| Note: Currently, Kmesh only supports link-level authentication. |
|
@nlgwcy Please update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #322
Special notes for your reviewer:
Does this PR introduce a user-facing change?: