Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elements with role="dialog" or role="alertdialog" do not have accessible names. #503

Open
lerni opened this issue Apr 1, 2024 · 0 comments

Comments

@lerni
Copy link

lerni commented Apr 1, 2024

Klaro Config
Behaviour is present on klaro.org
After updating to klaro 0.7.22, div#klaro-cookie-notice.cookie-notice has role="dialog" and causes PageSpeed to complain like: Elements with role="dialog" or role="alertdialog" do not have accessible names.

HTML Code of Page
see above

Steps to reproduce
Run PageSpeedInsights on klaro
https://googlechrome.github.io/lighthouse/viewer/?psiurl=https%3A%2F%2Fklaro.org%2F&strategy=mobile&category=accessibility#aria-dialog-name

Current behavior
After update to 0.7.22 PageSpeed starts to complain

Expected behavior
No additional complaints after updating

Related to: #100

Edited 21st of May: I see now, that with v0.7.21, config.showNoticeTitle was introduced. Just showing aria-labelledby if config.showNoticeTitle is true would make sense IMHO.

Thanks for working on klaro !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant