Fix item size calculation inside layoutGroup #126
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ichiko This change breaks existing behavior (Run example app and see AdaptiveSectionsViewController). This PR cannot be merged as-is. I will investigate the correct solution.
|
|
Sorry I missed checking all examples.Thank you for your investigating. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #125
I think itemSize should not ignore effectiveSizeForContainer.
https://github.com/kishikawakatsumi/IBPCollectionViewCompositionalLayout/blob/master/Sources/IBPCollectionViewCompositionalLayout/IBPCollectionCompositionalLayoutSolver.m#L108
At least this changes work well reproduction code https://github.com/ichiko/IBPCVCLLayoutGroupContentInsetsBug