• Only 1 call to setBannerHeight, right here.

"Here" being:

This was part of KMKeyboard.onConfigurationChanged before #11722, which spins it off into onSizeChanged, which does (also) override an existing built-in View method. ("Also" because onConfigurationChanged does too.)

• 4 calls to setOskHeight

• Same code block as seen under setBannerHeight
• KMKeyboard.onResume, as noted in the description
  • The intent of that code, re: height, is to reuse the previously-set height and force the internal Web engine to re-layout the OSK.

• keyman/android/KMEA/app/src/main/java/com/keyman/engine/KMManager.java

  Lines 2059 to 2070 in d868337

  	public static void applyKeyboardHeight(Context context, int height) {
  	if (isKeyboardLoaded(KeyboardType.KEYBOARD_TYPE_INAPP)) {
  	InAppKeyboard.loadJavascript(KMString.format("setOskHeight('%s')", height));
  	RelativeLayout.LayoutParams params = getKeyboardLayoutParams();
  	InAppKeyboard.setLayoutParams(params);
  	}
  	if (isKeyboardLoaded(KeyboardType.KEYBOARD_TYPE_SYSTEM)) {
  	SystemKeyboard.loadJavascript(KMString.format("setOskHeight('%s')", height));
  	RelativeLayout.LayoutParams params = getKeyboardLayoutParams();
  	SystemKeyboard.setLayoutParams(params);
  	}
  	}

  • Assuming fix(android): fix keyboard size after rotation and restore via onSizeChanged, after layout #11722 goes through, the calls there can almost certainly be dropped. onSizeChanged should trigger after the setLayoutParams calls go through. (There may be a need to invalidate() -> requestLayout() in order to flush the changes.)
  • This block appears to account for 2 of the 4 calls.

• 2 calls to setOskWidth

• Same code block as seen under setBannerHeight
• KMKeyboard.onResume, as noted in the description

I feel as if onResume is always paired with an onConfigurationChanged call. If it's possible to determine this to be true by investigation, we can probably drop onResume entirely in favor of onConfigurationChanged, passing all keyboard-dimension synchronization through the single code block seen under setBannerHeight's entry above.

If I'm wrong about that, worst-case, we can probably just .setLayoutParams to trigger a relayout, then use onSizeChanged from #11722 to set the dimensions - also from a single, central location.