feat(email): Add auth_id in email types and send auth_id in email URLs
#5120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+447
to
+448
| token_only_query_param: web::Query<user_api::TokenOnlyQueryParam>, | ||
| auth_id_query_param: web::Query<user_api::AuthIdQueryParam>, |
There was a problem hiding this comment.
how we are differentiating between two in request?
ThisIsMani
added
C-feature
apoorvdixit88
approved these changes
Jun 26, 2024
racnan
approved these changes
Jun 26, 2024
Comment on lines
51
to
+53
| req_payload.clone(), | ||
| |state, _, req_body, _| user_core::signup_with_merchant_id(state, req_body), | ||
| |state, _, req_body, _| { | ||
| user_core::signup_with_merchant_id(state, req_body, auth_id.clone()) |
There was a problem hiding this comment.
Will pickup in upcoming PRs.
There was a problem hiding this comment.
Unable to do this, as the ApiMetricEvent should be implemented for payload. That means, if I use a tuple like (req, auth_id), then I have to implement ApiMetricEvent for (ReqType, String)
lsampras
approved these changes
Jun 26, 2024
pixincreate
added a commit
that referenced
this pull request
Jun 28, 2024
…ay/hyperswitch into iatapay-through-hyperswitch-cypress * 'iatapay-through-hyperswitch-cypress' of github.com:juspay/hyperswitch: feat(router): skip apple pay session call if the browser is not Safari (#5136) fix(opensearch): show search results only if user has access permission to the index (#5097) chore(version): 2024.06.27.0 feat(users): add endpoint for terminate auth select (#5135) feat(users): implemented openidconnect (#5124) feat(router): add payments manual-update api (#5045) fix(docs): open-api fix for payment response (#5103) refactor(connector): [AdyenPlatform]Throw 4xx instead of 5xx for source_balance_account (#4990) feat: realtime user analytics (#5098) refactor(connector): added amount conversion framework for cashtocode (#4857) feat(email): Add `auth_id` in email types and send `auth_id` in email URLs (#5120) refactor(connector): add amount framework to payme & Trustpay with googlePay, ApplePay for bluesnap, Noon & Trustpay (#4833) fix(connector): [BOA/CYBS] make risk information message optional (#5107) chore(version): 2024.06.25.1 fix(router): skip serialize if none for assurance_details_required in googlepay session response (#5118) refactor: separate DB queries and HTML creation for payout links (#4967) feat(router): updated `last_used_at` field for apple pay and google pay for CITs (#5087) fix(payment_methods): use existing field value of `nick_name` in db if not sent during request (#5105) chore(version): 2024.06.25.0
pixincreate
added a commit
that referenced
this pull request
Jun 28, 2024
…ay/hyperswitch into refactor-error-handling-in-cypress * 'iatapay-through-hyperswitch-cypress' of github.com:juspay/hyperswitch: chore: clean up feat(router): skip apple pay session call if the browser is not Safari (#5136) fix(opensearch): show search results only if user has access permission to the index (#5097) chore(version): 2024.06.27.0 feat(users): add endpoint for terminate auth select (#5135) feat(users): implemented openidconnect (#5124) feat(router): add payments manual-update api (#5045) fix(docs): open-api fix for payment response (#5103) refactor(connector): [AdyenPlatform]Throw 4xx instead of 5xx for source_balance_account (#4990) feat: realtime user analytics (#5098) refactor(connector): added amount conversion framework for cashtocode (#4857) feat(email): Add `auth_id` in email types and send `auth_id` in email URLs (#5120) refactor(connector): add amount framework to payme & Trustpay with googlePay, ApplePay for bluesnap, Noon & Trustpay (#4833) fix(connector): [BOA/CYBS] make risk information message optional (#5107) chore(version): 2024.06.25.1 fix(router): skip serialize if none for assurance_details_required in googlepay session response (#5118) refactor: separate DB queries and HTML creation for payout links (#4967) feat(router): updated `last_used_at` field for apple pay and google pay for CITs (#5087) fix(payment_methods): use existing field value of `nick_name` in db if not sent during request (#5105) chore(version): 2024.06.25.0
ThisIsMani
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR will introduce
auth_idfield in email types and also email APIs.When an email is triggered from a API which gets
auth_id, then that will be used to construct the email URL as well.Additional Changes
Motivation and Context
Closes #5119.
How did you test it?
All the following APIs will accept a query param called
auth_id.Example:
In the email received from the API, the url in the email will also have the same
auth_idquery param which is the same value as above.auth_idparam is optional, and if it is not sent, the email link also will not have any parameter.Checklist
cargo +nightly fmt --allcargo clippy