-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing directory slashes when completion chosen #3859
Comments
Is this WSL? Looks like you're running an fzf binary for Windows that uses backslash as the file separator. How did you install fzf? |
Please comment if you still have the problem with a linux binary. |
Hi, thanks for responding, this is not WSL, this is zsh installed directly on windows, being used in windows terminal. Yes this is still an issue. I am unable to use WSL because it's a Virtual Box windows image, and for some reason I can't get the nested virtualisation to work. I think I installed it with the shallow clone as per the instructions - https://github.com/timabell/dotmatrix/blob/2e554b3093b4d0f8c53f8f2730f0aef63c9e4774/software/fzf.sh#L5-L6 - let me know if you want me to check anything on the windows machine to add more details. |
Oh, so does zsh transform the path separators on Windows so you can access paths in Unix style? If that is the case, the Window binary of fzf needs a way to use forward-slashes instead. Related: BurntSushi/ripgrep#1667 (comment) |
Checklist
man fzf
)Output of
fzf --version
0.53.0 (c4a9ccd)
OS
Shell
Problem / Steps to reproduce
Thanks for the fab tool.
For a new windows install I'm working on I am getting the backslashes that separate directories all go missing when I hit enter to choose an entry which then means the path is corrupted.
I have done a load of searching and can't find any mention of this being an issue anywhere or what it might be. I don't know enough about how fzf works to guess further so any ideas welcome.
Begin a completion with
![image](https://private-user-images.githubusercontent.com/19378/339475293-7f2235c6-44c9-4c30-94a9-935495e2ee65.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkzODc4NDEsIm5iZiI6MTcxOTM4NzU0MSwicGF0aCI6Ii8xOTM3OC8zMzk0NzUyOTMtN2YyMjM1YzYtNDRjOS00YzMwLTk0YTktOTM1NDk1ZTJlZTY1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI2VDA3MzkwMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWI2ZTI0Yzc3ZTIxMzA5OGY1ODYzZGNiZjg0YWQ4ODhlODUwMGQ5ODIxYjA5Y2RmNDQxOWIzMGViNjBjYWViYWMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.DVPTaXy_T0ceYP0KtraNP1bJG8nZAyVgE3qpFEn9D7o)
file **<tab>
:Hit
![image](https://private-user-images.githubusercontent.com/19378/339475410-de10d73a-7ae0-472f-9b1b-bb6602cff5df.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkzODc4NDEsIm5iZiI6MTcxOTM4NzU0MSwicGF0aCI6Ii8xOTM3OC8zMzk0NzU0MTAtZGUxMGQ3M2EtN2FlMC00NzJmLTliMWItYmI2NjAyY2ZmNWRmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI2VDA3MzkwMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTczZTA2NTQyZDU1NGRiZTNmNDU0NjMxYmNkZmQxMmViYzk3OTFmOWQ2OWQ3NWZiMTI1ODA1ZTEwM2NkMDdlYjcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Tm2EPTZky0H8qtSxfa5Ve4yFXcPXXwsQBjDSGYQ-3SI)
enter
to choose an item in a subfolder and all the slashes are missing:Curiously if I call
fzf
directly and then search it works fine:This is my dotmatrix config for the windows machine (windows branch) at time of writing https://github.com/timabell/dotmatrix/blob/0c0de5b7107de4a43c22f1f6c727b2537ffc1056/.zshrc#L107
The text was updated successfully, but these errors were encountered: