-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Directories not walked recursively in FUSE mounted directories #3832
Comments
Do you have any custom configuration? env | grep FZF_
print -l ${(ok)functions} | grep _fzf_compgen |
Uncached and cached results for readdir were inconsistent -- the former returned correct stat info for directory entries while the latter didn't. That's because only names of entries were saved in cache without stat info. In turn this leads to issues like junegunn/fzf#3832 since directory traversal library (https://github.com/charlievieth/fastwalk in this case) relies on proper stat info returned by readdir. Hence when unchached result was returned it gave proper outcome, while with cached result it was wrong. Cache stat info next to entry name to fix the issue. While file attributes are saved in cache already, they use full path as key. To avoid potentially plenty of allocations, string copying and cache lookups to get each attr, let's keep a copy of stat struct independently to be on the fast path.
Turns out it's an issue caused by caching mechanism in It started to affect On the other hand previous |
Also submitted charlievieth/fastwalk#18 to match |
Checklist
man fzf
)Output of
fzf --version
0.52.1 (6432f00)
OS
Shell
Problem / Steps to reproduce
test
and try to complete files:test
tomnt
overssh
$ cd .. $ sshfs localhost:test mnt
mnt
and try to complete files:Expected result: same as for local filesystem
Actual result: only top level items are listed
Now the really weird thing is that for some commands it works fine in both cases
ls **<TAB>
orcat **<TAB>
, but not in othersvim **<TAB>
ormpv **<TAB
.The text was updated successfully, but these errors were encountered: