Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused variables in initial-variables.scss #3842

Open
theHacker opened this issue Jun 13, 2024 · 0 comments
Open

Unused variables in initial-variables.scss #3842

theHacker opened this issue Jun 13, 2024 · 0 comments

Comments

@theHacker
Copy link

This is about Bulma.
It seems to be a bug.

Overview of the problem

This is a Sass issue: I'm using version [1.0.1]
I am sure this issue is not a duplicate.

Description

I was looking in the Sass sources what can be configured, and I stumbled on $speed.
Curious what this is controlling, I searched for usages. But there are none.

It seems like some values in themes/light.scss are hard-coded instead of using their values from initial-variables.scss.
Comparing themes/light.scss

      // Other
      "block-spacing": iv.$block-spacing,
      "duration": 294ms,
      "easing": ease-out,
      "radius-small": iv.$radius-small,
      "radius": iv.$radius,
      "radius-medium": iv.$radius-medium,
      "radius-large": iv.$radius-large,
      "radius-rounded": 9999px,
      "speed": 86ms,

with
initial-variables.scss

// Miscellaneous

$easing: ease-out !default;
$radius-small: 0.25rem !default;
$radius: 0.375rem !default;
$radius-medium: 0.5em !default;
$radius-large: 0.75rem !default;
$radius-rounded: 9999px !default;
$speed: 86ms !default;

one notices, $easing, $radius-rounded and $speed are not used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant