Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamic subscription #359

Open
newearthmartin opened this issue Jan 31, 2021 · 2 comments
Open

dynamic subscription #359

newearthmartin opened this issue Jan 31, 2021 · 2 comments

Comments

@newearthmartin
Copy link
Contributor

Hi @dokterbob et al!

I'm thinking of a new feature and would like to get your feedback on it. I'm going to do it on my own repo but I think it can be useful for others and could be merged.

The feature is a dynamic/subscriptionless newsletter. The idea is to have code that dynamically chooses who to send messages to, at the moment of submitting a message. This can be done two ways:

  • Use an existing newsletter and add a filter_class option to the Message. This filter class will have a method that returns True or False on subscriptions and this will be used to dynamically select who receives this message
  • Add a new type of Newsletter that doesn't have Subscription objects but rather a subscription_generator_class that dynamically produces the list of recipients that should get the message.

Either of these dynamic mechanisms will be triggered when the message is submitted.

Would love to have your feedback, any potential issues that I'm not seeing, etc

@woodz-
Copy link

woodz- commented Feb 3, 2021

would love to see your pull request

@newearthmartin
Copy link
Contributor Author

@dokterbob
@woodz-

Hi! I created a PR for this feature
#367

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants