Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support imports in proto files (grpc task) #1403

Open
kalantar opened this issue Feb 17, 2023 · 0 comments
Open

Support imports in proto files (grpc task) #1403

kalantar opened this issue Feb 17, 2023 · 0 comments
Labels
area/tasks Iter8 tasks

Comments

@kalantar
Copy link
Member

Is your feature request related to a problem? Please describe.
The Iter8 grpc task requires a proto file. This is specified using a URL via the protoURL property.

A proto file can import other proto files. See https://protobuf.dev/programming-guides/proto/#importing. Import paths are relative.

Iter8 cannot correctly handle imports.

Describe the solution you'd like
imports should work.

Iter8 copies the proto file to the cluster (to the pod executing the experiment). It will need to process the proto file to find any imports and fetch those as well.
@kalantar kalantar added the area/tasks Iter8 tasks label Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/tasks Iter8 tasks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kalantar