Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDR dimming external display when turned on. #4979

Open
1 task
RoseAF1 opened this issue Jun 6, 2024 · 3 comments
Open
1 task

HDR dimming external display when turned on. #4979

RoseAF1 opened this issue Jun 6, 2024 · 3 comments

Comments

@RoseAF1
Copy link

RoseAF1 commented Jun 6, 2024

System and IINA version:

  • macOS Sonoma 14.5
  • IINA 1.3.5 build 141

Expected behavior:
Play HDR video at expected brightness.

Actual behavior:
When HDR video is dragged to external HDR monitor, the brightness dims to an unusable level

Steps to reproduce:
While viewing an HDR video from an external monitor, toggle HDR mode on from an M2 pro macbook pro.

  • MPV does not have this problem.

How often does this happen?
Every time i play an HDR video on my M2 pro macbook pro.

Just got this M2 pro a few days ago. I was enjoying HDR video in iina on my 2019 macbook before. Apple support was unable to fix the issue after 2 days as there were also issues with HDR distortion in all browsers besides safari. Fortunately, I saw that there was a makeshift fix in these forums that actually fixed both the browser and video players hdr issues. Was just wondering if there was a more definite fix today as the ones i read were from last year.

@low-batt
Copy link
Contributor

low-batt commented Jun 6, 2024

The M2 & M3 problems are suggestive of a macOS defect as M1 does not exhibit these problems. So we have been hoping the problems would disappear in a macOS release.

That the workarounds work we can't explain either. Feels like there is some faulty graphics optimization in macOS that doesn't get applied when you change the environment. But this is all speculation.

Interesting to hear that Safari does not exhibit the problem, but other browsers do. I don't remember that being reported before.

Right at this moment IINA is working on upgrading libmpv. Possibly the mpv project has found a workaround or fix for this problem. We will have to see once we have a version of IINA working with updated dependencies.

@RoseAF1
Copy link
Author

RoseAF1 commented Jun 6, 2024

Makes sense. If it's of any interest to you or anyone with the same problem, I did have to enable hardware acceleration in browser for these makeshift fixes to work in any chromium browser (as i said, hdr already works in safari without problem). The fixes worked in IINA without touching anything within IINA so as you've said, it's definitely not an IINA issue.

@low-batt
Copy link
Contributor

low-batt commented Jun 7, 2024

That hardware acceleration must be enabled for the workarounds to work in a chromium browser is another new puzzling piece of evidence. On a M chip hardware acceleration offloads decoding work from the CPUs to the Media Engine. Odd that doing so would enable the workarounds to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants