Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The right time label shows xx:xx- instead of -xx:xx when in .remaining mode in Hebrew #4946

Open
1 task done
uiryuu opened this issue May 25, 2024 · 2 comments
Open
1 task done

The right time label shows xx:xx- instead of -xx:xx when in .remaining mode in Hebrew #4946

uiryuu opened this issue May 25, 2024 · 2 comments
Labels
feature: ui/ux progress: fixed/implemented type: localization

Comments

@uiryuu
Copy link
Member

uiryuu commented May 25, 2024

System and IINA version:

  • macOS 14.5
  • IINA Latest enable-he branch

Expected behavior:
-xx:xx, as in other languages. Need to check with @ShlomoCode
image

Actual behavior:
image

Steps to reproduce:

  • Open IINA in Hebrew
  • Start a video, and click on the right time label to make it to show the remaining time
  • MPV does not have this problem.

How often does this happen?
Always
@ShlomoCode
Copy link
Contributor

-xx:xx, as in other languages. Need to check with @ShlomoCode

Agreed

uiryuu added a commit that referenced this issue May 29, 2024
@uiryuu
Fix DurationDisplayTextField flipped when having minus sign in RTL #4946
a817dd8
@uiryuu uiryuu mentioned this issue May 29, 2024
Merged
2 tasks
uiryuu added a commit that referenced this issue May 29, 2024
@uiryuu
Fix DurationDisplayTextField flipped when having minus sign in RTL #4946
f51d9fa
uiryuu added a commit that referenced this issue May 29, 2024
@uiryuu
Fix DurationDisplayTextField flipped when having minus sign in RTL #4946
b143a21
uiryuu added a commit that referenced this issue May 29, 2024
@uiryuu
Fix DurationDisplayTextField flipped when having minus sign in RTL #4946
3fbd064
@low-batt
Copy link
Contributor

@uiryuu The touch bar is still showing xx:xx-. That view needs to be fixed as well.

low-batt added a commit that referenced this issue Jun 1, 2024
@low-batt
Fix Touch Bar time remaining label in RTL, #4946
2b1f15f 
This commit will change the touchBar method in TouchBarSupport to set
baseWritingDirection to leftToRight on the DurationDisplayTextField that
shows time remaining.

This is a follow-up to PR #4958 which changed the baseWritingDirection
in the XIB for the OSC. That fix is correct, but does not fix the
DurationDisplayTextField created at runtime by  TouchBarSupport. This
commit corrects the TouchBarSupport use case.
@low-batt low-batt mentioned this issue Jun 1, 2024
Merged
2 tasks
uiryuu pushed a commit that referenced this issue Jun 1, 2024
@low-batt
Fix Touch Bar time remaining label in RTL, #4946 (#4967)
9196c56 
This commit will change the touchBar method in TouchBarSupport to set
baseWritingDirection to leftToRight on the DurationDisplayTextField that
shows time remaining.

This is a follow-up to PR #4958 which changed the baseWritingDirection
in the XIB for the OSC. That fix is correct, but does not fix the
DurationDisplayTextField created at runtime by  TouchBarSupport. This
commit corrects the TouchBarSupport use case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature: ui/ux progress: fixed/implemented type: localization
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lhc70000 @uiryuu @ShlomoCode @low-batt