Numbers on the sliders in QuickSettingView not centered

[uiryuu]

System and IINA version:

• macOS 14.5 (23F79)
• IINA 1.3.4

Expected behavior:
Numbers are centered to the knob in the slides.

Actual behavior:
Numbers are not centered. This is more obvious when the strings are short. Example:

This also effects other 2 sliders for delay:

Corresponding code for generating the constraint:

iina/iina/QuickSettingViewController.swift

Lines 573 to 579 in 18d4205

	private func redraw(indicator: NSTextField, constraint: NSLayoutConstraint, slider: NSSlider, value: String) {
	indicator.stringValue = value
	let offset: CGFloat = 6
	let sliderInnerWidth = slider.frame.width - offset * 2
	constraint.constant = offset + sliderInnerWidth * CGFloat((slider.doubleValue - slider.minValue) / (slider.maxValue - slider.minValue))
	view.layout()
	}

My guess is that this piece of code used to work in older macOS version, but due to macOS UI updates, the offset (or width of the slider) changes, so it broke the UI. Manually subtracting 2 from constraint.constant seems fix the problem, but that introduces even more magic numbers.

Steps to reproduce:
Open quicksettingview and navigate to the related pages.

• MPV does not have this problem.

How often does this happen?
Always.

[low-batt]

I noticed this when working on #4904, but did not address it. Was going to ask about it.

Details about the changes Apple made to sliders can be found here: macOS Big Sur changes for developers / Controls

The changes will need to be conditionalized to preserve the alignment in older macOS versions. This is what it looks like in macOS 10.15.7: