Hebrew locale not work in Sparkle

[uiryuu]

System and IINA version:

• macOS macOS 14.4.1
• IINA enable-he branch

Expected behavior:
Sparkle is running in Hebrew

Actual behavior:

Steps to reproduce:

• Start IINA for the first time in Hebrew

It seems the sparkle has support for Hebrew locale (https://github.com/sparkle-project/Sparkle/tree/2.x/Sparkle/he.lproj). Didn't spent too much time into this. Just created this issue as a reminder.

• MPV does not have this problem.

How often does this happen?
Should be always

[ShlomoCode]

This seems to be intentional behavior from Sparkle, they use the MacOS language and not the language defined for the app
sparkle-project/Sparkle#1083 (comment)

[uiryuu]

No, by "provided by macOS" they meant the language option provided by the macOS at runtime. Xcode will inject this option when we intend to run the app in a different language than the system language. The root cause of this is that the Hebrew localization is not completed, so untranslated strings can be only shown in English. See this

Clearly it knows that we are running in Hebrew, but just lacking some Hebrew translations. I'm labeling upstream.

[ShlomoCode]

but just lacking some Hebrew translations. I'm labeling upstream.

sparkle-project/Sparkle#2573