Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RunCommand less bad #27957

Open
pbehne opened this issue Jun 20, 2024 · 1 comment
Open

Make RunCommand less bad #27957

pbehne opened this issue Jun 20, 2024 · 1 comment

Comments

@pbehne
Copy link
Contributor

pbehne commented Jun 20, 2024

The sole purpose of the RunCommand tester is to, as the name implies, run an arbitrary command. This capability already exists with the command parameter in the RunApp tester. An investigation should be conducted to assess the feasibility of potential actions to reduce code duplication. Options are:

  1. Get ride of RunCommand completely, replace its usage with RunApp.
  2. Modify RunApp so it inherits from RunCommand and does not have to implement its own command parameter.
  3. ...

If the RunCommand tester is kept, it should be updated to support all options from the class it is derived from (currently Tester). For instance, Tester has the cli_args parameter, but setting it in a RunCommand test has no effect. If a parent parameter cannot be supported, it should be moved to a more derived class or deleted in the class that can't support it.

@pbehne
Copy link
Contributor Author

pbehne commented Jun 20, 2024

Tag @permcody

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant