Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in the FindYPlus routine #27800

Open
freiler opened this issue Jun 5, 2024 · 0 comments · May be fixed by #27889
Open

Error in the FindYPlus routine #27800

freiler opened this issue Jun 5, 2024 · 0 comments · May be fixed by #27889
Assignees
@freiler
Labels
C: Modules/Navier Stokes Tickets pertaining to the navier_stokes module P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.

Comments

@freiler
Copy link
Contributor

freiler commented Jun 5, 2024

Bug Description

The findYPlus routine in Navier Stokes Methods computes the yplus iteratively.
However, the error of the current guess with respect to the old guess in the previous iteration is missing the absolute value, incurring in errors in the computation of the yplus.

Steps to Reproduce

Currently, running the routine yields an error in the yplus value calculation.

Impact

The impact is the miscalculation of the dimensionless wall distance, leading to a miscaracterization of the turbulence field. Impacts turbulence production kernels, turbulent viscosity wall functions and first cell wall distance determination in the meshing process.

[Optional] Diagnostics

No response
@freiler freiler added P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations. labels Jun 5, 2024
freiler pushed a commit to freiler/moose that referenced this issue Jun 5, 2024
Fix findYPlus routine
0a6304d 
Closes idaholab#27800
@freiler freiler mentioned this issue Jun 5, 2024
Closed
@lindsayad lindsayad added the C: Modules/Navier Stokes Tickets pertaining to the navier_stokes module label Jun 5, 2024
freiler pushed a commit to freiler/moose that referenced this issue Jun 12, 2024
Fix findYPlus routine. idaholab#27800
30b6c65
@freiler freiler linked a pull request Jun 12, 2024 that will close this issue
Open
freiler added a commit to freiler/moose that referenced this issue Jun 17, 2024
@freiler @tanoret
Apply suggestions from code review @tanoret idaholab#27800 idaholab#2…
56c819f 
…7887 idaholab#27888

Co-authored-by: Mauricio Tano <[email protected]>
freiler added a commit to freiler/moose that referenced this issue Jun 17, 2024
@freiler
Update INSFVTurbulentViscosityWallFunction.md idaholab#27800 idaholab…
2644c98 
…#27887 idaholab#27888
freiler added a commit to freiler/moose that referenced this issue Jun 17, 2024
@freiler @tanoret
Apply suggestions from code review idaholab#27800 idaholab#27887 idah…
f4b59bf 
…olab#27888

Co-authored-by: Mauricio Tano <[email protected]>
freiler added a commit to freiler/moose that referenced this issue Jun 17, 2024
@freiler
Update INSFVTKEDSourceSink.md idaholab#27800 idaholab#27887 idaholab#…
9007949 
…27888
freiler added a commit to freiler/moose that referenced this issue Jun 17, 2024
@freiler @tanoret
Apply suggestions from code review idaholab#27800 idaholab#27887 idah…
23a650a 
…olab#27888

Co-authored-by: Mauricio Tano <[email protected]>
freiler added a commit to freiler/moose that referenced this issue Jun 17, 2024
@freiler
Update INSFVTKESourceSink.md idaholab#27800 idaholab#27887 idaholab#2…
3da84bc 
…7888
freiler added a commit to freiler/moose that referenced this issue Jun 17, 2024
@freiler
Update kEpsilonViscosityAux.h idaholab#27800 idaholab#27887 idaholab#…
2a258f4 
…27888
freiler added a commit to freiler/moose that referenced this issue Jun 17, 2024
@freiler
Update INSFVTurbulentViscosityWallFunction.h idaholab#27800 idaholab#…
0e676b1 
…27887 idaholab#27888
freiler added a commit to freiler/moose that referenced this issue Jun 17, 2024
@freiler
Update INSFVTKEDSourceSink.h idaholab#27800 idaholab#27887 idaholab#2…
39a5793 
…7888
freiler added a commit to freiler/moose that referenced this issue Jun 17, 2024
@freiler
Update INSFVTKESourceSink.h idaholab#27800 idaholab#27887 idaholab#27888
3dece3c
freiler added a commit to freiler/moose that referenced this issue Jun 17, 2024
@freiler @tanoret
Apply suggestions from code review idaholab#27800 idaholab#27887 idah…
af9bcf8 
…olab#27888

Co-authored-by: Mauricio Tano <[email protected]>
freiler added a commit to freiler/moose that referenced this issue Jun 17, 2024
@freiler
Update RANSYPlusAux.C idaholab#27800 idaholab#27887 idaholab#27888
cab9c69
freiler added a commit to freiler/moose that referenced this issue Jun 17, 2024
@freiler
Update kEpsilonViscosityAux.C idaholab#27800 idaholab#27887 idaholab#…
2850420 
…27888
freiler added a commit to freiler/moose that referenced this issue Jun 17, 2024
@freiler
Update kEpsilonViscosityAux.C idaholab#27800 idaholab#27887 idaholab#…
c0a984b 
…27888
freiler added a commit to freiler/moose that referenced this issue Jun 17, 2024
@freiler
Update SIMPLENonlinearAssembly.C idaholab#27800 idaholab#27887 idahol…
b1f7cb1 
…ab#27888
freiler added a commit to freiler/moose that referenced this issue Jun 17, 2024
@freiler
Update INSFVTurbulentViscosityWallFunction.C idaholab#27800 idaholab#…
6df0240 
…27887 idaholab#27888
freiler added a commit to freiler/moose that referenced this issue Jun 17, 2024
@freiler @tanoret
Apply suggestions from code review idaholab#27800 idaholab#27887 idah…
aea93a2 
…olab#27888

Co-authored-by: Mauricio Tano <[email protected]>
freiler added a commit to freiler/moose that referenced this issue Jun 17, 2024
@freiler
Update kEpsilonViscosityAux.C idaholab#27800 idaholab#27887 idaholab#…
723294d 
…27888
freiler added a commit to freiler/moose that referenced this issue Jun 17, 2024
@freiler
Update INSFVTKESourceSink.C idaholab#27800 idaholab#27887 idaholab#27888
09babc9
freiler added a commit to freiler/moose that referenced this issue Jun 17, 2024
@freiler
Apply suggestions from code review @tanoret idaholab#27800 idaholab#2…
ca966fb 
…7887 idaholab#27888

Co-authored-by: Mauricio Tano <[email protected]>

Addressing tanoret review changes idaholab#27800 idaholab#27887 idaholab#27888
freiler added a commit to freiler/moose that referenced this issue Jun 17, 2024
@freiler
Apply suggestions from code review @tanoret idaholab#27800 idaholab#2…
6cfee09 
…7887 idaholab#27888

Co-authored-by: Mauricio Tano <[email protected]>

Addressing tanoret review changes idaholab#27800 idaholab#27887 idaholab#27888
freiler added a commit to freiler/moose that referenced this issue Jun 18, 2024
@freiler
Apply suggestions from code review @tanoret idaholab#27800 idaholab#2…
e0ffe99 
…7887 idaholab#27888
freiler pushed a commit to freiler/moose that referenced this issue Jun 24, 2024
Fix findYPlus routine. idaholab#27800
03453c3
freiler added a commit to freiler/moose that referenced this issue Jun 24, 2024
@freiler
Apply suggestions from code review @tanoret idaholab#27800 idaholab#2…
85613d9 
…7887 idaholab#27888

Co-authored-by: Mauricio Tano <[email protected]>

Addressing tanoret review changes idaholab#27800 idaholab#27887 idaholab#27888
freiler added a commit to freiler/moose that referenced this issue Jun 24, 2024
@freiler
Apply suggestions from code review @tanoret idaholab#27800 idaholab#2…
f90682a 
…7887 idaholab#27888
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@freiler freiler

Labels
C: Modules/Navier Stokes Tickets pertaining to the navier_stokes module P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

K epsilon mods freiler/moose
2 participants
@lindsayad @freiler