Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uhyve fails on odd memory sizes. #265

Open
mkroening opened this issue Jan 2, 2022 · 2 comments
Open

Uhyve fails on odd memory sizes. #265

mkroening opened this issue Jan 2, 2022 · 2 comments

Comments

@mkroening
Copy link
Member

These tests need a rework:

https://github.com/hermitcore/uhyve/blob/d3ac0f568082d9a696b6e9e8d649850c0c15c859/src/vm.rs#L859-L915

Running benches_data/hello_world with 12599 KiB fails with another strange error, while using 12500 KiB works.
mkroening added a commit to mkroening/uhyve that referenced this issue Jan 2, 2022
@mkroening
Remove memory size unit tests
8e21658 
These tests are obsolete once the guest memory minimum is enforced.

Replacing these tests is tracked in hermit-os#265.
mkroening added a commit to mkroening/uhyve that referenced this issue Jan 3, 2022
@mkroening
Remove memory size unit tests
90c765c 
These tests are obsolete once the guest memory minimum is enforced.

Replacing these tests is tracked in hermit-os#265.
mkroening added a commit to mkroening/uhyve that referenced this issue Jan 3, 2022
@mkroening
Remove memory size unit tests
73547f1 
These tests are obsolete once the guest memory minimum is enforced.

Replacing these tests is tracked in hermit-os#265.
mkroening added a commit to mkroening/uhyve that referenced this issue Jan 3, 2022
@mkroening
Remove memory size unit tests
80f9c2a 
These tests are obsolete once the guest memory minimum is enforced.

Replacing these tests is tracked in hermit-os#265.
@jounathaen
Copy link
Member

Since these tests were removed in 80f9c2a, I guess we can close this one.

@mkroening
Copy link
Member Author

The tests need reintroduction in a reworked form. They were obsolete in their old form, but as the main comment says:

Running benches_data/hello_world with 12599 KiB fails with another strange error, while using 12500 KiB works.

@mkroening mkroening reopened this Jun 22, 2023
@jounathaen jounathaen changed the title Improve memory size errors Uhyve fails on odd memory sizes. Jun 23, 2023
@jounathaen jounathaen mentioned this issue Jun 27, 2023
Merged
@n0toose n0toose mentioned this issue Jun 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jounathaen @mkroening