fix: unable to bind ngIf in angular 17+ #9314
Open
+75
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use new angular control flow to avoid missing directive while mocking child templates Solves help-me-mom#8884
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9314 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 227 227
Lines 4935 4939 +4
Branches 1147 1148 +1
=========================================
+ Hits 4935 4939 +4 ☔ View full report in Codecov by Sentry. |
|
@satanTime Is there anything I need to change in this PR to help it get in & released ? (other than rebasing of course) This issue is currently preventing use of |
|
Hi @sabrina-10kc, Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When component templates contain child templates, they are replaced with a mock template that contains a
*ngIfthis causes a failure when the component doesn't have NgIf imported.Though this problem likely exists in some pre-angular 17 situations, it has been causing new failures to appear as people upgrade since 3rd party angular components are starting to use the new control flow syntax and no longer import
CommonModule/NgIf.Instead the mock template now uses
@ifsyntax if angular is 17 or higher.Fixes #8884