Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: MockMiddleware{Index} #7844

Open
cheng93 opened this issue Jan 5, 2024 · 1 comment
Open

Bug: MockMiddleware{Index} #7844

cheng93 opened this issue Jan 5, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@cheng93
Copy link

cheng93 commented Jan 5, 2024

Description of the bug

I have thousands of MockMiddleware{Index} not being cleaned up.

An example of the bug

Unfortunately I don't have a sample atm

https://github.com/cheng93/ng-mocks-reset

Expected vs actual behavior

MockMiddleware{Index} to be destroyed if not in cacheDeclaration

image

Misc

I am on the latest 14.12.1
I haven't been able to update ng-mocks since 14.9.0.
Upgrading to 14.10.0 and later gives me this issue.

I get the following CI, but it's fine locally.

image

Instincts to points to memory leak.

This and the other bug reported today, I believe, are the causes.

@cheng93 cheng93 added the bug Something isn't working label Jan 5, 2024
@cheng93
Copy link
Author

cheng93 commented Jan 5, 2024

image

This looks to only affecting Angular 17, after the following API was introduced

https://github.com/angular/angular/blob/17.0.8/packages/core/src/render3/deps_tracker/deps_tracker.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants