feat: add labels for helm release #1046
Conversation
yxxhero
changed the title
yxxhero
force-pushed
the
add-labels-for-syncrelease
branch
from
c33c17d
to
39bcf40
Compare
| @@ -2563,6 +2571,8 @@ func (st *HelmState) flagsForUpgrade(helm helmexec.Interface, release *ReleaseSp | |||
|
|
|||
| flags = st.appendHelmXFlags(flags, release) | |||
|
|
|||
| flags = st.appendLabelsFlags(flags, helm, release) | |||
There was a problem hiding this comment.
The release label in helmfile only allows users to choose release. Is it necessary to add it to helm installation parameters?
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
yxxhero
force-pushed
the
add-labels-for-syncrelease
branch
from
2b16d1b
to
918d5a7
Compare
|
@mumoshu WDYT? Looking forward to your feedback. thanks so much. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Signed-off-by: yxxhero <[email protected]>
Signed-off-by: yxxhero <[email protected]>
Signed-off-by: yxxhero <[email protected]>
Signed-off-by: yxxhero <[email protected]>
Signed-off-by: yxxhero <[email protected]>
Signed-off-by: yxxhero <[email protected]>
Signed-off-by: yxxhero <[email protected]>
Signed-off-by: yxxhero <[email protected]>
Signed-off-by: yxxhero <[email protected]>
Signed-off-by: yxxhero <[email protected]>
Signed-off-by: yxxhero <[email protected]>
yxxhero
force-pushed
the
add-labels-for-syncrelease
branch
from
918d5a7
to
62026c0
Compare
| { | ||
| name: "empty label value", | ||
| labels: map[string]string{"foo": ""}, | ||
| want: "foo=null", |
There was a problem hiding this comment.
| want: "foo=null", | |
| want: "foo=", |
Probably we want this presuming "null" and ""(empty string) are two different things and it's actually an empty string here
| for _, k := range keys { | ||
| val := labels[k] | ||
| if val == "" { | ||
| val = "null" |
There was a problem hiding this comment.
| func (st *HelmState) SelectReleases(includeTransitiveNeeds bool) ([]Release, error) { | ||
| values := st.Values() | ||
| rs, err := markExcludedReleases(st.Releases, st.Selectors, st.CommonLabels, values, includeTransitiveNeeds) | ||
| rs, err := markExcludedReleases(st.Releases, st.Selectors, values, includeTransitiveNeeds) |
There was a problem hiding this comment.
Hmmm.. not ideal but probably we'd better do assign releases with labels here so that we won't accidentally miss calling GetReleasesWithLabels()
| rs, err := markExcludedReleases(st.Releases, st.Selectors, values, includeTransitiveNeeds) | |
| st.Releases = st.GetReleasesWithLabels() | |
| rs, err := markExcludedReleases(st.Releases, st.Selectors, values, includeTransitiveNeeds) |
There was a problem hiding this comment.
And make it a private func getReleasesWithLabels so that it is clearer that the function is not supposed to be called by the consumer of State
|
Any update on this? @yxxhero |
helm/helm#10533