Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add curly single and double quotes to BRACKETS #10971

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Add curly single and double quotes to BRACKETS #10971

merged 1 commit into from
Jun 18, 2024

Conversation

adiabatic
Copy link
Contributor

Closes #10966.

The change works fine on my computer. I'm not sure what, if anything, else I should be checking.

Thanks to @the-mikedavis for pointing out where to make this change.

@the-mikedavis the-mikedavis added the A-core Area: Helix core improvements label Jun 17, 2024
@pascalkuthe pascalkuthe merged commit 69acf66 into helix-editor:master Jun 18, 2024
6 checks passed
@woojiq
Copy link
Contributor

woojiq commented Jun 18, 2024 •
edited
Loading

It should be in PAIRS (variable below), not in BRACKETS. Because you can't tell if a quote is opening or closing. It may probably break the matching logic 🙂
UPD: nevermind, I didn't see they are different actually :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

@pascalkuthe pascalkuthe pascalkuthe approved these changes

Assignees
No one assigned
Labels
A-core Area: Helix core improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mr"“/mr"” replaces double quotes with two pairs of the same kind of double quote
4 participants
@adiabatic @woojiq @the-mikedavis @pascalkuthe