Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cursorline wrong when inlay hint takes several lines #10924

Open
giann opened this issue Jun 11, 2024 · 3 comments
Open

Cursorline wrong when inlay hint takes several lines #10924

giann opened this issue Jun 11, 2024 · 3 comments
Labels
A-helix-term Area: Helix term improvements C-bug Category: This is a bug

Comments

@giann
Copy link

giann commented Jun 11, 2024

Summary

When an inlay hints takes several lines, the current line highlight is off by that amount of lines.

Screenshot 2024-06-11 at 08 02 22

Reproduction Steps

No response

Helix log

No response

Platform

macOS

Terminal Emulator

wezterm 20230712-072601-f4abf8fd

Installation Method

brew

Helix Version

helix 24.3 (2cadec0)

@giann giann added the C-bug Category: This is a bug label Jun 11, 2024
@gabydd
Copy link
Member

gabydd commented Jun 11, 2024

Just for anyone looking at this the current line highlighting is the cursor-line on the UnwrappedNull line not syntax highlighting, that confused me for a bit

@the-mikedavis the-mikedavis changed the title Current line highlight wrong when inlay hint takes several lines Cursorline wrong when inlay hint takes several lines Jun 11, 2024
@RoloEdits
Copy link
Contributor

RoloEdits commented Jun 12, 2024

Here is a minimal setup to reproduce. Using zig 0.13 and zls 0.13.

const std = @import("std");
const fs = @import("std").fs;

pub fn main() !void {
    const real_path = fs.realpath(pathname, &buf);
}

The error set should expand:
image

I also noticed some behavior where if you go far enough past the length it pops up again, as maybe was expected, but when going back up it stayed on the correct line for a while before disappearing again , when in the act of going down those lines didnt have it.

helix_cursorline_virtualtext

Also to note: the diagnostic virtual text from #6417 disappear.

@giann
Copy link
Author

giann commented Jun 13, 2024

Another thing is that it prevents scrolling up with the mouse wheel sometimes.

@kirawi kirawi added the A-helix-term Area: Helix term improvements label Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements C-bug Category: This is a bug
Projects
None yet
Development

No branches or pull requests

4 participants