Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fails: TestInstancePrincipalsAuthenticationDetailsProvider #8870

Open
al3xandru opened this issue Jun 11, 2024 · 1 comment
Open

Test fails: TestInstancePrincipalsAuthenticationDetailsProvider #8870

al3xandru opened this issue Jun 11, 2024 · 1 comment
Assignees
Labels
4.x Version 4.x bug Something isn't working OCI SE
Projects

Comments

@al3xandru
Copy link

Environment Details

  • Helidon Version: 4.0.10
  • Build from source
  • JDK version: JDK 21.0.3
  • OS: Linux

Problem Description

The following test io.helidon.integrations.oci.sdk.cdi.TestInstancePrincipalsAuthenticationDetailsProvider.testThatInstancePrincipalsAuthenticationDetailsProviderAlwaysTakesManySecondsToRun fails while building from source.

Steps to reproduce

The build is run in a special environment that seems to result in an unexpected behavior for this test (i.e. getting a response back too fast).

@github-actions github-actions bot added this to Triage in Backlog Jun 11, 2024
@tomas-langer tomas-langer changed the title Test fails: TestInstancePrincipalsAuthenticationDetailsProvider.testThatInstancePrincipalsAuthenticationDetailsProviderAlwaysTakesManySecondsToRun Test fails: TestInstancePrincipalsAuthenticationDetailsProvider Jun 11, 2024
@tomas-langer
Copy link
Member

testThatInstancePrincipalsAuthenticationDetailsProviderAlwaysTakesManySecondsToRun()

This fails because the metadata endpoint IP address is available, and the test expects it is not.
there are two possibilities:

  • it is the "real" metadata service endpoint (i.e. this is running on OCI), and it should succeed
  • it is just a coincidence, and in that case the io.helidon.integrations.oci.sdk.runtime.OciAvailabilityDefault#runningOnOci method should return false (after catching an exception).

In addition the library should be on classpath of the test (the exception that was received should never be received, even if running on OCI).

I think there should be an assumption that if the test runs on OCI, it should just be skipped (and the same in helidon-integrations-oci and in helidon-integrations-sdk-cdi module tests).

@edbratt edbratt added bug Something isn't working SE OCI 4.x Version 4.x labels Jun 13, 2024
@edbratt edbratt moved this from Triage to High priority in Backlog Jun 13, 2024
@klustria klustria moved this from High priority to Sprint Scope in Backlog Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x bug Something isn't working OCI SE
Projects
Backlog
  
Sprint Scope
Development

No branches or pull requests

4 participants