Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.x: WebServer double compression (re-encoding) #8837

Open
barchetta opened this issue Jun 4, 2024 · 0 comments
Open

4.x: WebServer double compression (re-encoding) #8837

barchetta opened this issue Jun 4, 2024 · 0 comments
Labels
4.x Version 4.x bug Something isn't working media-support Media type processing in SE P2 webserver
Projects

Comments

@barchetta
Copy link
Member

barchetta commented Jun 4, 2024

Environment Details

  • Helidon Version: 4.0.8
  • Helidon SE

Problem Description

A customer has reported that WebServer will compress outgoing responses even if the handler sets Content-Encoding: gzip on the response. Apparently in Helidon 3 if the Content-Encoding header was set then the content would not be re-encoded.

The documentation does not describe how explicitly setting Content-Encoding by the handler impacts content negotiation.

Also, it appears as though the enable-compression configuration option was removed in 4.x. The only place I found this was in tests/functional/mp-compression. I'm guessing that's leftover cruft.

The upgrade guide does not mention what happened to enable-compression. Maybe it should.

Steps to reproduce

Reproducer:

ContentEncodingTest.java.txt

@barchetta barchetta added webserver media-support Media type processing in SE 4.x Version 4.x labels Jun 4, 2024
@github-actions github-actions bot added this to Triage in Backlog Jun 4, 2024
@m0mus m0mus added bug Something isn't working P2 labels Jun 27, 2024
@m0mus m0mus moved this from Triage to High priority in Backlog Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x bug Something isn't working media-support Media type processing in SE P2 webserver
Projects
Backlog
  
High priority
Development

No branches or pull requests

2 participants