Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French Language #5769

Closed
naif0s opened this issue Jun 10, 2024 · 6 comments · Fixed by #5873
Closed

French Language #5769

naif0s opened this issue Jun 10, 2024 · 6 comments · Fixed by #5873

Comments

@naif0s
Copy link

naif0s commented Jun 10, 2024

Description of the issue

How can I contribute to the project by adding the French language?

@lexiv0re
Copy link
Contributor

lexiv0re commented Jun 10, 2024

Hi @naif0s, it would be really great to add French language support.
One can find all the translations in lang folders across the repo. They contain separate files with translations for different languages. The following PRs can be used as an example of adding new translations (they might not contain all the necessary folders to update though): https://github.com/hcengineering/platform/pulls?q=is%3Apr+is%3Amerged+spanish

@ygranger-oa
Copy link

Hi,

@naif0s if you need help...

@naif0s
Copy link
Author

naif0s commented Jun 13, 2024

Hi, @ygranger-oa

I've started translating a few files, how do you want to proceed?

@ygranger-oa
Copy link

I can check your commits before your pull request.

@dingdayu
Copy link
Contributor

Hi, @ygranger-oa @lexiv0re I also want to help provide Chinese language pack.

I found the following three language packages in the project. Can you introduce them?

  • packages/ui/lang/en.json
  • packages/core/lang/en.json
  • server/account/lang/en.json

Via https://github.com/hcengineering/platform/pull/4788/files I noticed that plugins have different language packages. Do I need to translate them separately?

If there is bootstrapping documentation, that would be great. If not, I'd like to start with what the UI can see, and then provide translations for Plugins.

@lexiv0re
Copy link
Contributor

Hello @dingdayu, adding Chinese language support would be really great as well! If you intend to work on that, could you please create a separate GitHub issue to keep this one focused on discussions about French language support? Thanks!

To add full support all packages and plugins need to be translated. Plugins form UI as well as packages so you won't see any real difference between them from the translation point of view.

You are right that to get the full list of files one can search for en.json files. E.g.:
image

As for the documentation, at the moment there's not much more than in the main readme file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants